Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3295: Fix issue with Accumulo iterators when smart merging Federated POC #3296

Merged
merged 8 commits into from
Sep 19, 2024

Conversation

tb06904
Copy link
Member

@tb06904 tb06904 commented Sep 13, 2024

There was an issue where the iterators from Accumulo could be exhausted or closed before the merging of elements had completed. There's not a great way around this other than to buffer the data into a set before using for merging. This does of course increase memory usage but might be faster overall.
(Also the previous solution was still technically buffering to memory with a distict() call).

Related issue

@tb06904 tb06904 linked an issue Sep 13, 2024 that may be closed by this pull request
p29876
p29876 previously approved these changes Sep 16, 2024
cn337131
cn337131 previously approved these changes Sep 17, 2024
p29876
p29876 previously approved these changes Sep 17, 2024
@tb06904 tb06904 dismissed stale reviews from p29876 and cn337131 via 0fbb929 September 17, 2024 14:15
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.77%. Comparing base (4ce1ec5) to head (d770cff).
Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
...imple/merge/operator/ElementAggregateOperator.java 63.15% 3 Missing and 4 partials ⚠️
...e/operation/handler/FederatedOperationHandler.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3296   +/-   ##
==========================================
  Coverage      67.77%   67.77%           
  Complexity      2595     2595           
==========================================
  Files            949      949           
  Lines          30237    30242    +5     
  Branches        3339     3341    +2     
==========================================
+ Hits           20492    20497    +5     
+ Misses          8279     8278    -1     
- Partials        1466     1467    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cn337131 cn337131 added bug Confirmed or suspected bug federated-store Specific to/touches the federated-store module labels Sep 18, 2024
@cn337131 cn337131 added this to the 2.4.0 milestone Sep 18, 2024
@j69772 j69772 merged commit 4007ee3 into develop Sep 19, 2024
21 of 22 checks passed
Copy link

sonarcloud bot commented Sep 19, 2024

@j69772 j69772 deleted the gh-3295-accumulo-iterators-issue-federated-poc branch September 19, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed or suspected bug federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Accumulo iterators in federated POC
4 participants