Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh-3299: Add ChangeGraphId operation to POC simple federated store #3301

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

cn337131
Copy link
Member

@cn337131 cn337131 commented Sep 18, 2024

PR adds a ChangeGraphId, mainly for accumulo stores, to the POC federated store.

Related issue

@cn337131 cn337131 added enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module labels Sep 18, 2024
@cn337131 cn337131 added this to the 2.4.0 milestone Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 75.55556% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.83%. Comparing base (6471de9) to head (76e0c99).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ffer/federated/simple/operation/ChangeGraphId.java 66.66% 7 Missing ⚠️
...v/gchq/gaffer/federated/simple/FederatedStore.java 88.88% 2 Missing ⚠️
...e/operation/handler/misc/ChangeGraphIdHandler.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3301      +/-   ##
=============================================
+ Coverage      67.82%   67.83%   +0.01%     
  Complexity      2595     2595              
=============================================
  Files            949      951       +2     
  Lines          30292    30337      +45     
  Branches        3341     3342       +1     
=============================================
+ Hits           20545    20580      +35     
- Misses          8280     8291      +11     
+ Partials        1467     1466       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cn337131 cn337131 marked this pull request as ready for review September 20, 2024 09:20
tb06904
tb06904 previously approved these changes Sep 24, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

@wb36499 wb36499 merged commit 5960ac1 into develop Sep 30, 2024
27 of 28 checks passed
@wb36499 wb36499 deleted the gh-3299-change-graph-id-operation-fed-poc branch September 30, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality/feature federated-store Specific to/touches the federated-store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ChangeGraphId operation to simple federated POC
4 participants