-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh-3300: Graph access controls for federated POC #3307
Open
tb06904
wants to merge
12
commits into
develop
Choose a base branch
from
gh-3300-access-control-federated-poc
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trol-federated-poc
…trol-federated-poc
…trol-federated-poc
tb06904
added
federated-store
Specific to/touches the federated-store module
feature
A proposed new feature
labels
Sep 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3307 +/- ##
=============================================
+ Coverage 67.84% 67.88% +0.03%
Complexity 2595 2595
=============================================
Files 951 952 +1
Lines 30353 30442 +89
Branches 3344 3358 +14
=============================================
+ Hits 20594 20666 +72
- Misses 8292 8304 +12
- Partials 1467 1472 +5 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional access controls for graphs added to federated stores to prevent users having visibility or modifying graphs they don't have access to.
Follows a similar concept to the old federated store by using the existing
AccessControlledResource
class and associated framework already in place. One main difference isgraphAuths
no longer exist they can instead be defined inside theDefaultUserPredicate
or custom predicate, this would look something like the following if done via JSON:Related issue