Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh-3300: Graph access controls for federated POC #3307

Merged
merged 19 commits into from
Oct 14, 2024

add option to skip on failure

51d4609
Select commit
Loading
Failed to load commit list.
Refresh
Merged

Gh-3300: Graph access controls for federated POC #3307

add option to skip on failure
51d4609
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 30, 2024 in 1s

67.88% (+0.03%) compared to 9d4563d

View this Pull Request on Codecov

67.88% (+0.03%) compared to 9d4563d

Details

Codecov Report

Attention: Patch coverage is 86.50794% with 17 lines in your changes missing coverage. Please review.

Project coverage is 67.88%. Comparing base (9d4563d) to head (51d4609).

Files with missing lines Patch % Lines
...hq/gaffer/federated/simple/operation/AddGraph.java 72.72% 6 Missing ⚠️
...e/operation/handler/FederatedOperationHandler.java 50.00% 4 Missing and 1 partial ⚠️
...ple/operation/handler/misc/RemoveGraphHandler.java 71.42% 2 Missing ⚠️
...mple/operation/handler/FederatedOutputHandler.java 88.88% 0 Missing and 1 partial ⚠️
.../simple/operation/handler/add/AddGraphHandler.java 91.66% 0 Missing and 1 partial ⚠️
.../operation/handler/get/GetAllGraphInfoHandler.java 92.30% 0 Missing and 1 partial ⚠️
...e/operation/handler/misc/ChangeGraphIdHandler.java 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop    #3307      +/-   ##
=============================================
+ Coverage      67.84%   67.88%   +0.03%     
  Complexity      2595     2595              
=============================================
  Files            951      952       +1     
  Lines          30353    30442      +89     
  Branches        3344     3358      +14     
=============================================
+ Hits           20594    20666      +72     
- Misses          8292     8304      +12     
- Partials        1467     1472       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov