Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-fs/eos-client: new package #1212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Berrysoft
Copy link
Contributor

  • Add eos-client.
  • Patch /etc directory.

@Berrysoft Berrysoft marked this pull request as ready for review August 14, 2023 09:15
@Berrysoft
Copy link
Contributor Author

The code of eos hardcoded the /etc/eos directory. It's messive to change it to ${EPREFIX}/etc/eos. Is that OK?

@heroxbd
Copy link
Contributor

heroxbd commented Aug 14, 2023

The common/fmt directory is empty. It is a submodule in the upstream. Shall we populate its contents?

@heroxbd
Copy link
Contributor

heroxbd commented Aug 15, 2023

dev-libs/libfmt is there.

There are plenty of submodules of git that needs to be downloaded and extracted before heading to src_prepare, much like the https://github.com/gentoo/sci/blob/203194ee62f8d4ffce6fb8278078b693af3ec87f/sci-libs/pytorch/pytorch-1.10.2.ebuild

@Berrysoft
Copy link
Contributor Author

Most of them could be replaced by the system dependencies without changes. The cmake script of eos seems clever enough.

src_prepare() {
default

cmake_src_prepare
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both default and cmake_src_prepare are going to try and apply any user patches. The second try will cause the build to fails since the patches are already applied. You can probably drop the entire explicit src_prepare phase.


src_install() {
cmake_src_install
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to set src_compile and src_install if you're only using the standard function.

LICENSE="GPL-3"

SLOT="0"
KEYWORDS="~amd64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to keep the layout as close to the ebuild skeleton as possible. (i.e. move LICENSE one line down)

DEPEND="${RDEPEND}"

BDEPEND="
dev-lang/python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this requires python during build time, it should be inheriting python-any-r1.eclass and setting PYTHON_COMPAT to the supported python versions.

@Nowa-Ammerlaan
Copy link
Member

Nowa-Ammerlaan commented Aug 17, 2023

The code of eos hardcoded the /etc/eos directory. It's messive to change it to ${EPREFIX}/etc/eos. Is that OK?

I think for ::sci this is fine.

Most of them could be replaced by the system dependencies without changes. The cmake script of eos seems clever enough.

Lets use system versions whenever possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants