Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProviderCache: Add option to separate cache between providers #1045

Merged
merged 1 commit into from
Jun 30, 2023
Merged

ProviderCache: Add option to separate cache between providers #1045

merged 1 commit into from
Jun 30, 2023

Conversation

AntoineLemaire
Copy link
Contributor

Fix #1044

@AntoineLemaire
Copy link
Contributor Author

Hello! Any news regarding this topic? :)

@jbelien
Copy link
Member

jbelien commented Nov 21, 2021

Hello @AntoineLemaire ,

Thank you for your contribution.
It looks good to me. Could you add a test for this new feature ?

Thanks.

@AntoineLemaire
Copy link
Contributor Author

@jbelien I've just added a test to verify that cacheKeys are differents :)

@AntoineLemaire AntoineLemaire changed the title ProviderCache: Add option to separate cache between realProvider name ProviderCache: Add option to separate cache between providers Nov 27, 2021
@Nyholm Nyholm closed this Jun 30, 2023
@AntoineLemaire
Copy link
Contributor Author

@Nyholm ? 😢

@Nyholm
Copy link
Member

Nyholm commented Jun 30, 2023

I did a big cleanup. Closed anything without activity the last few months. (Without actually looking too much on the prs)

I’ll be happy to open this again. I also see that you were waiting for review.

@Nyholm Nyholm reopened this Jun 30, 2023
@AntoineLemaire
Copy link
Contributor Author

@Nyholm I'm actually using a fork in production because of that, it's true that I never force ping anyone here
Who should I ping for review? @jbelien ?

norkunas
norkunas approved these changes Jun 30, 2023
View reviewed changes
src/Provider/Cache/ProviderCache.php Outdated Show resolved Hide resolved
Nyholm
Nyholm approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing.

src/Provider/Cache/ProviderCache.php Outdated Show resolved Hide resolved
@Nyholm Nyholm merged commit 5556556 into geocoder-php:master Jun 30, 2023
@Nyholm
Copy link
Member

Nyholm commented Jun 30, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple cached provider shared same cacheKeys
4 participants
@AntoineLemaire @jbelien @Nyholm @norkunas