chore: add testruns for PHP 8.4

[Chris53897]

No description provided.

[ruudk]

Thanks for doing this.

@jbelien What's needed to get this merged? Anything I can do to help?

[ruudk]

@Nyholm Would you be able to help out with this?

[Chris53897]

There is one failing test for PHP 8.4 low.
https://github.com/geocoder-php/Geocoder/actions/runs/11325637108/job/31492962515?pr=1235

I guess we need to bump the minimum version of http-client? v7.0.10 ?

[ruudk]

Since symfony/http-client is a dev dependency, I think this is fine to do.

We can change it to:

-"symfony/http-client": "^5.4 || ^6.4 || ^7.0",
+"symfony/http-client": "^5.4 || ^6.4 || ^7.0.10",

[ruudk]

@Chris53897 could you make the change?

[Chris53897]

I bumped the min version to ^5.4.45 to solve it.

[Nyholm]

I think it looks good

[ruudk]

@Chris53897 Looks good, only a few PHP CS Fixer issues left and we can ship it! 🎉

[Chris53897]

I have created a seperate PR for this.Am 14.11.2024 um 10:04 schrieb Ruud Kamphuis ***@***.***>: @Chris53897 Looks good, only a few PHP CS Fixer issues left and we can ship it! 🎉 —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[ruudk]

Why, would have been easier for everyone if it was done in this one, so we could have just merged it and be done with it. Now you have to rebase this PR later again.