Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subplots, fix #230 #233

Closed
wants to merge 1 commit into from
Closed

Conversation

Robinlovelace
Copy link
Contributor

No description provided.

@Robinlovelace Robinlovelace linked an issue Jun 8, 2024 that may be closed by this pull request
@Robinlovelace
Copy link
Contributor Author

Update isn't perfect but it works:

image

There may be other examples where we need to do this so putting as PR, feel free to merge @michaeldorman

@michaeldorman
Copy link
Collaborator

michaeldorman commented Jun 10, 2024

Thanks for looking into this @Robinlovelace ! It's a great idea to make the figures as single image files, and solves the issue, but it also makes the code significantly more complicated with no added value to the readers. From #230 (comment) it seems like this is going to be fixed in quarto.
The question is whether we should

  • rely on the future fix and keep using the multi-column layout, or
  • switch to your solution which would make the code longer but more independent of quarto

I suggest the former, unless this is not fixed in time and then we'll have no choice but to use the latter

@Nowosad
Copy link
Member

Nowosad commented Jun 10, 2024

@michaeldorman there is also a third possible solution (I do not know if the best): you could show the shorter code, but instead of running it -- you could just provide an image in that place (just remember to redo the code when the quarto fix is ready).

@michaeldorman
Copy link
Collaborator

@michaeldorman there is also a third possible solution (I do not know if the best): you could show the shorter code, but instead of running it -- you could just provide an image in that place (just remember to redo the code when the quarto fix is ready).

Right, didn't think of that! This is an interesting alternative. IMHO @Robinlovelace 's solution is preferable, because the entire book shows the code as-is, so we should try to stick to that. It it's just temporary then you're right it would be nice to have this kind of setup with alternative images, but it comes at a cost of lots of work to prepare and manage the images and keep track of their reproducibility, so I'd still lean towards @Robinlovelace 's solution to keep things straightforward

@Robinlovelace
Copy link
Contributor Author

Closing this PR because it will soon be a non-issue and fixed upstream: quarto-dev/quarto-cli#9927 (comment)

@Robinlovelace Robinlovelace deleted the 230-some-figures-are-stretched branch June 10, 2024 20:57
@Robinlovelace
Copy link
Contributor Author

Related thought: should we start an impact.csv for this book?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some figures are stretched
3 participants