Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 11: Use of Kernel.open or IO.read or similar sinks with a non-constant value #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

george-gca
Copy link
Owner

Fixes https://github.com/george-gca/multi-language-al-folio/security/code-scanning/11

To fix the problem, we will replace the use of URI.open with URI(url).open. This change ensures that the URL is parsed and validated before being opened, reducing the risk of command injection. We will make this change in the download_fonts and download_images methods.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

…similar sinks with a non-constant value

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for multi-language-al-folio failed. Why did it fail? →

Name Link
🔨 Latest commit 000995b
🔍 Latest deploy log https://app.netlify.com/sites/multi-language-al-folio/deploys/66f313350ab436000831fd09

@george-gca george-gca marked this pull request as ready for review September 24, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant