Skip to content

Commit

Permalink
fix test to not run when the FF is disabled (elastic#114260)
Browse files Browse the repository at this point in the history
Fixes elastic#113661

Don't run the tests when the feature is disabled.


Co-authored-by: Elastic Machine <[email protected]>
  • Loading branch information
2 people authored and georgewallace committed Oct 25, 2024
1 parent ad1b34b commit 796fca2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions muted-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,6 @@ tests:
- class: org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT
method: test {categorize.Categorize SYNC}
issue: https://github.com/elastic/elasticsearch/issues/113722
- class: org.elasticsearch.xpack.esql.expression.function.scalar.convert.ToDateNanosTests
issue: https://github.com/elastic/elasticsearch/issues/113661
- class: org.elasticsearch.ingest.geoip.DatabaseNodeServiceIT
method: testNonGzippedDatabase
issue: https://github.com/elastic/elasticsearch/issues/113821
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;

import org.elasticsearch.common.time.DateUtils;
import org.elasticsearch.xpack.esql.action.EsqlCapabilities;
import org.elasticsearch.xpack.esql.core.expression.Expression;
import org.elasticsearch.xpack.esql.core.tree.Source;
import org.elasticsearch.xpack.esql.core.type.DataType;
Expand All @@ -29,6 +30,9 @@ public ToDateNanosTests(@Name("TestCase") Supplier<TestCaseSupplier.TestCase> te

@ParametersFactory
public static Iterable<Object[]> parameters() {
if (EsqlCapabilities.Cap.TO_DATE_NANOS.isEnabled() == false) {
return List.of();
}
final String read = "Attribute[channel=0]";
final List<TestCaseSupplier> suppliers = new ArrayList<>();

Expand Down

0 comments on commit 796fca2

Please sign in to comment.