Update v2024.2.0 deps #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Sep 20, 2024
nginx.dockerfile
Outdated
| @@ -14,7 +14,7 @@ RUN files/prebuild/build-frontend.sh | |||
|
|
|||
| # when upgrading, look for upstream changes to redirector.conf | |||
| # also, confirm setup-odk.sh strips out HTTP-01 ACME challenge location | |||
| FROM jonasal/nginx-certbot:5.0.1 | |||
| FROM jonasal/nginx-certbot:5.0.4 | |||
There was a problem hiding this comment.
CircleCI seems to be complaining about this image for some reason.
There was a problem hiding this comment.
I switched some numbers around is why. Sorry, I intended to open as draft!
There was a problem hiding this comment.
Sorry, didn't mean to arrive early to the party!
There was a problem hiding this comment.
Haha, I've done my checks and gotten my numbers straight now so I'll take your approval. Thank you! 🥳
|
Do you have time to update Node in central-backend and central-frontend as well (package.json / Volta / maybe CI)? npm yells at me whenever I install dependencies for Frontend because Web Forms is expecting a later Node. I'm happy to do that update also. |
|
Yep, can do that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #649
What has been done to verify that this works as intended?
Tried on dev, verified basic happy paths.
Why is this the best possible solution? Were any other approaches considered?
I searched for the previous node version so hopefully got all of those this time!
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
There are no significant expected changes in behavior. pyxform and Enketo releases are relatively small. No major version bumps anywhere.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)