Solved: On screen rotation selected forms get unselected #120 #342
Conversation
There was a problem hiding this comment.
Hello @HarshitSachan1999 Thanks for the PR, looks like a duplicate of #248
|
@Chromicle I had't seen #248. The issue is marked as open therefore i thought that no solution has been proposed. What should I do now ? |
| @@ -83,7 +83,8 @@ | |||
|
|
|||
| <activity | |||
| android:name=".views.ui.send.SendFormsActivity" | |||
| android:parentActivityName=".views.ui.main.MainActivity"> | |||
| android:parentActivityName=".views.ui.main.MainActivity" | |||
| android:configChanges="keyboardHidden|orientation|screenSize"> | |||
There was a problem hiding this comment.
@HarshitSachan1999 we should not handle screen orientation changes using manifest changes.
There was a problem hiding this comment.
@lakshyagupta21 Does this mean that I have to look for some other method to resolve it ?
|
Closing this PR, @HarshitSachan1999 please go through the Github issue once you find any suitable issue and check if there are any open PR references or not, before start working on any issue. I know @opendatakit-bot is behaving very weird nowadays and we'll try to rectify the issue. |
Closes #
What has been done to verify that this works as intended?
I checked it by running the app in android device.
Why is this the best possible solution? Were any other approaches considered?
I found it best solution as it includes only one line of code in manifest file and it also solves bug #247. Yes, firstly I tried to save the changes within activity file but that wasn't working.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I am not finding any regression risk.
Before submitting this PR, please make sure you have:
./gradlew checkCodeand confirmed all checks still pass OR confirm CircleCI build passes