feat(start): Add more context to what is going on underneath the hood for start #148
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 90.35% 90.53% +0.18%
==========================================
Files 20 20
Lines 1026 1035 +9
==========================================
+ Hits 927 937 +10
+ Misses 99 98 -1 ☔ View full report in Codecov by Sentry. |
IanWoodard
approved these changes
Nov 16, 2024
| @@ -12,6 +12,7 @@ | |||
| DEVSERVICES_DEPENDENCIES_CACHE_DIR = os.path.join(DEVSERVICES_CACHE_DIR, "dependencies") | |||
| DEVSERVICES_DEPENDENCIES_CACHE_DIR_KEY = "DEVSERVICES_DEPENDENCIES_CACHE_DIR" | |||
| STATE_DB_FILE = os.path.join(DEVSERVICES_LOCAL_DIR, "state") | |||
| DOCKER_COMPOSE_COMMAND_LENGTH = 7 | |||
There was a problem hiding this comment.
Is this the same across all docker compose commands or is it only true for up?
| cmd: list[str], current_env: dict[str, str], status: Status, len_options: int | ||
| ) -> subprocess.CompletedProcess[str]: | ||
| # TODO: Get rid of these constants, we need a smarter way to determine the containers being brought up | ||
| for dependency in cmd[DOCKER_COMPOSE_COMMAND_LENGTH:-len_options]: |
There was a problem hiding this comment.
I somewhat prefer the magic numbers if we can factor them out soon, but this is fine too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will more clearly state the steps that are happening underneath the hood for starting a service.