feat: Log when file not added to source bundle #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/log-skipped-non-utf-files
branch
from
03de2dd
to
a7fec72
Compare
loewenheim
approved these changes
Sep 9, 2024
When a file has an invalid (non-UTF-8) encoding, it is skipped from being added to source bundles. Previously, the file was silently skipped. Now, we log when we skip a file. Fixes #2135
szokeasaurusrex
force-pushed
the
szokeasaurusrex/log-skipped-non-utf-files
branch
from
a7fec72
to
d8808c8
Compare
szokeasaurusrex
deleted the
szokeasaurusrex/log-skipped-non-utf-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a file has an invalid (non-UTF-8) encoding, it is skipped from being added to source bundles. Previously, the file was silently skipped. Now, we log when we skip a file.
The logs are emitted at the
infolevel, which is hidden by default (default log level iswarn). To see these logs, users will need to set the log level, for example by passing--log-level=info.Fixes #2135
Fixes #2147