ci: update actions/upload-artifact to v4 with merge #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the new before: after: |
This reverts commit 6ff2435.
|
Hey @joshuarli, thanks for the PR. Just to confirm, have you tested already that this works, or is the only way to know for sure to attempt a new Sentry CLI release? |
I demonstrated above that the structure of the release artifact 8c24c96.zip is the same (cleaner). Build: https://github.com/getsentry/sentry-cli/actions/runs/10929197033 But yes, we won't know for sure until a new release is run in full since that has to go through craft. |
szokeasaurusrex
approved these changes
Sep 23, 2024
szokeasaurusrex
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit 5e71dcc.
szokeasaurusrex
added a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrying upload-artifact v4 update (see #2119) by using artifacts/merge to merge together multiple artifacts from different jobs into the single one named github.sha that craft expects.
Summarily, upload-artifact v3 is deprecated but v4 doesn't support mutating an artifact with the name name by uploading different filepaths to the same artifact. Because we need a single artifact "github.sha", we have to use actions/merge to create it. Alternatively craft could be modified but this is the easiest way forward and I like the idea of a unified artifact, it makes craft simpler.
ref: getsentry/craft#552