Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use --release when watching #5452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Jan 24, 2024

It's useful to eliminate false positives when benchmarking and watching.

@anonrig anonrig requested a review from a team as a code owner January 24, 2024 21:27
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want to do this then we should do it for make build-rs-dev as well, but i am somewhat cautious about the increased build time for regular snuba users

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5311b4) 90.20% compared to head (34ca1b1) 90.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5452   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files         889      889           
  Lines       43529    43529           
  Branches      288      288           
=======================================
  Hits        39265    39265           
  Misses       4222     4222           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants