-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax highlighting for Solidity, Vyper, and Cairo #1806
Open
jakelang
wants to merge
6
commits into
getzola:next
Choose a base branch
from
jakelang:add-solidity
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for that. I'm actually going to holdd off adding more syntaxes until #1787 has been decided since I don't want to add something just to remove it. |
The decision is not planned soon, especially since you can easily load your own syntaxes/themes. |
Keats
force-pushed
the
next
branch
2 times, most recently
from
June 24, 2024 21:04
8b1a413
to
67c2fe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
next
branch?If the change is a new feature or adding to/changing an existing one:
Description
This pull request adds syntax highlighting support for three languages from the Ethereum ecosystem.
All of the syntax files are sourced from https://github.com/davidhq/SublimeEthereum at the commit mentioned in
sublime/syntaxes/extra/README.md
. I did not add this repository as a submodule because I used Sublime to generate.sublime-syntax
files for Vyper and Cairo from their respective.tmlanguage
files.The aforementioned repository appears to be well-maintained with changes made 3 days ago to support Solidity 0.8.13. Credit goes to the maintainers of this repository for the syntax files.