-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docs.rs): cover more Mac targets #276
Conversation
3787428
to
09a9df7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Barring the cross-compilation issue, should iOS also be targeted for docs? I'm unsure if there's anything EDIT: And if such a PR makes the documentation available elsewhere, the "docs are broken" module comment should be replaced with a link :) |
@ErichDonGubler can you pursue this again? #5 was fixed and closed via #303, and running |
After all #303 was contained in the recent 0.28.0 release, and the default |
09a9df7
to
78968c4
Compare
78968c4
to
65427d5
Compare
@xorza: I've adjusted PR title, summary, and the sole commit to note that this only covers more targets, since that seems like the only useful scope left in this contribution. 🙂 |
@xorza: I've rebased, taken your review suggestion, adjusted PR title, summary, and the sole commit to note that this only covers more targets, since that seems like the only useful scope left in this contribution. 🙂 |
Nightly CI appears to be complaining about an "unused" feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to have all Tier 1/2 Apple platforms listed, and instead of setting a "useless" default-target
, no longer rely on the default targets = ["...windows..", "...linux...", ...]
array on which docs.rs will fail anyway: https://docs.rs/crate/metal/0.28.0/builds/1204445/x86_64-unknown-linux-gnu.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Expands the set of Mac targets to cover more Mac toolchains. 😀
Original OP text from draft
We've specified a
default-target
fordocs.rs
metadata inCargo.toml
, but the way to exclude other platforms is via thetargets
field, according to these docs on it:Should fix #5.EDIT: Maybe not?