This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
prefetch support #64
Open
prefetch support #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-head
approved these changes
Jun 25, 2020
gokulkrishnaa
approved these changes
Jun 25, 2020
added 2 commits
June 25, 2020 17:02
houndci-bot
reviewed
Jun 26, 2020
| @@ -70,6 +71,10 @@ def start | |||
| @connection.start | |||
| @channel = @connection.create_channel | |||
|
|
|||
| if @prefetch > 0 | |||
There was a problem hiding this comment.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Style/NumericPredicate: Use @prefetch.positive? instead of @prefetch > 0.
warmfusion
approved these changes
Jul 12, 2020
|
@sundbry - Can you resolve the merge conflicts for me please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.