Merge pull request #910 from hol430/bug/GenericGObject

Fix generic gobject types

src/Libs/GObject-2.0/Public/Object.Registration.cs

@@ -31,7 +31,14 @@ private Type GetGTypeOrRegister(System.Type type)
     private static class FallbackRegistrationStrategy
     {
         private static string QualifyName(System.Type type)
-            => type.FullName?.Replace(".", "") ?? type.Name;
+            => type.ToString()
+                .Replace(".", string.Empty)
+                .Replace("+", string.Empty)
+                .Replace("`", string.Empty)
+                .Replace("[", "_")
+                .Replace("]", string.Empty)
+                .Replace(" ", string.Empty)
+                .Replace(",", "_");
 
         public static void RegisterSubclassRecursive(System.Type type)
         {

src/Tests/Libs/GObject-2.0.Tests/Classes/GenericTypeRegistrationTests.cs

@@ -0,0 +1,44 @@
+using System;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+namespace GObject.Tests.Classes;
+
+internal class GenericClass : GObject.Object
+{
+    public GenericClass() : base(true, Array.Empty<GObject.ConstructArgument>())
+    {
+    }
+}
+internal class GenericClass<T> : GObject.Object
+{
+    public GenericClass() : base(true, Array.Empty<GObject.ConstructArgument>())
+    {
+    }
+}
+internal class GenericClass<T1, T2> : GObject.Object
+{
+    public GenericClass() : base(true, Array.Empty<GObject.ConstructArgument>())
+    {
+    }
+}
+
+[TestClass, TestCategory("UnitTest")]
+public class GenericTypeRegistrationTests
+{
+    private class NestedGenericClass<T> : GObject.Object
+    {
+        public NestedGenericClass() : base(true, Array.Empty<GObject.ConstructArgument>())
+        {
+        }
+    }
+
+    [TestMethod]
+    public void TestDynamicGenericTypeRegistration()
+    {
+        // (Invalid names will cause the test host to crash.)
+        using (new GenericClass<int, int>()) { };
+        using (new GenericClass<GenericClass, string>()) { };
+        using (new GenericClass<GenericClass<string>>()) { };
+        using (new NestedGenericClass<GenericClass<string>>()) { };
+    }
+}