Skip to content

Commit

Permalink
Merge pull request #108 from git-for-windows/aarc64-artifacts
Browse files Browse the repository at this point in the history
cascading-runs: also build ARM64 artifacts
  • Loading branch information
dscho authored Nov 18, 2024
2 parents c4475aa + a357bde commit 5c3510a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion GitForWindowsHelper/cascading-runs.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const triggerGitArtifactsRuns = async (context, checkRunOwner, checkRunRepo, tag

const architecturesToTrigger = []
const { listCheckRunsForCommit, queueCheckRun } = require('./check-runs')
for (const architecture of ['x86_64', 'i686']) {
for (const architecture of ['x86_64', 'i686', 'aarch64']) {
const workflowName = `git-artifacts-${architecture}`
const runs = await listCheckRunsForCommit(
context,
Expand Down
12 changes: 10 additions & 2 deletions __tests__/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ The \`tag-git\` workflow run [was started](https://url-to-tag-git/)
git-artifacts-x86_64 run already exists at <url-to-existing-x86_64-run>.
The \`git-artifacts-i686\` workflow run [was started](dispatched-workflow-git-artifacts.yml).
The \`git-artifacts-aarch64\` workflow run [was started](dispatched-workflow-git-artifacts.yml).
`)
return { html_url: 'https://github.com/git-for-windows/git/pull/4322#issuecomment-1450703020' }
}
Expand Down Expand Up @@ -751,6 +752,7 @@ test('a completed `tag-git` run triggers `git-artifacts` runs', async () => {
expect(context.res).toEqual({
body: `git-artifacts-x86_64 run already exists at <url-to-existing-x86_64-run>.
The \`git-artifacts-i686\` workflow run [was started](dispatched-workflow-git-artifacts.yml).
The \`git-artifacts-aarch64\` workflow run [was started](dispatched-workflow-git-artifacts.yml).
`,
headers: undefined,
status: undefined
Expand Down Expand Up @@ -819,20 +821,26 @@ The \`tag-git\` workflow run [was started](dispatched-workflow-tag-git.yml)`,
The \`git-artifacts-x86_64\` workflow run [was started](dispatched-workflow-git-artifacts.yml).
The \`git-artifacts-i686\` workflow run [was started](dispatched-workflow-git-artifacts.yml).
The \`git-artifacts-aarch64\` workflow run [was started](dispatched-workflow-git-artifacts.yml).
`,
headers: undefined,
status: undefined
})
expect(mockGetInstallationAccessToken).toHaveBeenCalled()
expect(mockGitHubApiRequestAsApp).not.toHaveBeenCalled()
expect(dispatchedWorkflows).toHaveLength(2)
expect(dispatchedWorkflows).toHaveLength(3)
expect(dispatchedWorkflows[0].html_url).toEqual('dispatched-workflow-git-artifacts.yml')
expect(dispatchedWorkflows[0].payload.inputs).toEqual({
architecture: 'i686',
architecture: 'aarch64',
tag_git_workflow_run_id: "341"
})
expect(dispatchedWorkflows[1].html_url).toEqual('dispatched-workflow-git-artifacts.yml')
expect(dispatchedWorkflows[1].payload.inputs).toEqual({
architecture: 'i686',
tag_git_workflow_run_id: "341"
})
expect(dispatchedWorkflows[2].html_url).toEqual('dispatched-workflow-git-artifacts.yml')
expect(dispatchedWorkflows[2].payload.inputs).toEqual({
architecture: 'x86_64',
tag_git_workflow_run_id: "341"
})
Expand Down

0 comments on commit 5c3510a

Please sign in to comment.