Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update NPM lockfile to v3 #109

Merged
merged 1 commit into from
Nov 18, 2024
Merged

build: update NPM lockfile to v3 #109

merged 1 commit into from
Nov 18, 2024

Conversation

dennisameling
Copy link
Contributor

While working on #108, I noticed some warnings in the npm install command:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @typescript-eslint/[email protected]
npm warn Found: [email protected]
npm warn node_modules/eslint
npm warn   dev eslint@"^9.15.0" from the root project
npm warn   2 more (@eslint-community/eslint-utils, eslint-plugin-jest)
npm warn
npm warn Could not resolve dependency:
npm warn peer eslint@"^7.0.0 || ^8.0.0" from @typescript-eslint/[email protected]
npm warn node_modules/eslint-plugin-jest/node_modules/@typescript-eslint/utils
npm warn   @typescript-eslint/utils@"^6.0.0 || ^7.0.0 || ^8.0.0" from [email protected]
npm warn   node_modules/eslint-plugin-jest
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/eslint
npm warn   peer eslint@"^7.0.0 || ^8.0.0" from @typescript-eslint/[email protected]
npm warn   node_modules/eslint-plugin-jest/node_modules/@typescript-eslint/utils
npm warn     @typescript-eslint/utils@"^6.0.0 || ^7.0.0 || ^8.0.0" from [email protected]
npm warn     node_modules/eslint-plugin-jest

By doing a simple npm update locally, the issue has disappeared. The update to lockfile v3 also greatly reduces the size of the lockfile.

This fixes some warnings regarding peer dependencies, and greatly reduces the size of the lockfile.

Signed-off-by: Dennis Ameling <[email protected]>
"lockfileVersion": 2,
"lockfileVersion": 3,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a look at the documentation and it seems that v3 was introduced with npm v7 (with v2 being a more bloated variant, but backwars-compatible with npm <v7). This corresponds to node.js v15, so I think we're good ;-)

@dscho dscho merged commit bba4c6a into main Nov 18, 2024
1 check passed
@dscho dscho deleted the update-dependencies branch November 18, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants