Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract spawn logic into a wrapper and add tests #953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extract spawn logic into a wrapper and add tests #953

wants to merge 2 commits into from

Commits on Sep 12, 2024

  1. git.ts: extract spawn logic into a wrapper and add tests 

    Currently, it's a bit hard to ensure that the code in git.exe actually does what we expect it to do, especially considering that we're calling things like please.sh and assume that some executables are available on the PATH.

Let's ensure we add some tests for these code paths, which we can easily extend with more tests if needed.

Signed-off-by: Dennis Ameling <[email protected]>
    @dennisameling
    dennisameling committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a8b04e0 View commit details
    Browse the repository at this point in the history

  2. npm run build && npm run package 

    Signed-off-by: Dennis Ameling <[email protected]>
    @dennisameling
    dennisameling committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9d4ed59 View commit details
    Browse the repository at this point in the history