Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-5vj8-g3qg-4qh6] An issue was discovered in MediaWiki before 1.35.10, 1.36... #4969

Conversation

Rudloff
Copy link

@Rudloff Rudloff commented Nov 1, 2024

Updates

  • Affected products
  • Source code location
  • Summary

Comments
Add Composer package

@github-actions github-actions bot changed the base branch from main to Rudloff/advisory-improvement-4969 November 1, 2024 14:26
@darakian
Copy link
Contributor

darakian commented Nov 1, 2024

Hi @Rudloff, thank you for the package find, but this edit seems incomplete based on the description.

@Rudloff
Copy link
Author

Rudloff commented Nov 1, 2024

Are you talking about the versions?
I was not sure how to add multiple ranges.

Also, is there a way to edit my PR with the GUI tool?

@darakian
Copy link
Contributor

darakian commented Nov 1, 2024

Yep the version ranges are missing and yes you can edit the PR without a GUI either via the github UI or by making a commit on the branch directly via a cli :)

As for how, each product can only have one version range, so you'll need to duplicate the package info for each affected range.

You can see an example here
https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/05/GHSA-vq3h-3q7v-9prw/GHSA-vq3h-3q7v-9prw.json

@Rudloff
Copy link
Author

Rudloff commented Nov 1, 2024

It looks like I don't have permission to push to the Rudloff-GHSA-5vj8-g3qg-4qh6 branch.
(The PR is not coming from my fork.)

@darakian
Copy link
Contributor

darakian commented Nov 1, 2024

Gotcha. Could you post it in this thread with any supporting commits/release notes/etc?

@Rudloff
Copy link
Author

Rudloff commented Nov 1, 2024

The ranges would be like this I think:

  "affected": [
    {
      "package": {
        "ecosystem": "Packagist",
        "name": "mediawiki/core"
      },
      "ranges": [
        {
          "type": "ECOSYSTEM",
          "events": [
            {
              "introduced": "0"
            },
            {
              "fixed": "1.35.10"
            }
          ]
        }
      ]
    },
    {
      "package": {
        "ecosystem": "Packagist",
        "name": "mediawiki/core"
      },
      "ranges": [
        {
          "type": "ECOSYSTEM",
          "events": [
            {
              "introduced": "1.36.0"
            },
            {
              "fixed": "1.38.6"
            }
          ]
        }
      ]
    },
    {
      "package": {
        "ecosystem": "Packagist",
        "name": "mediawiki/core"
      },
      "ranges": [
        {
          "type": "ECOSYSTEM",
          "events": [
            {
              "introduced": "1.39.0"
            },
            {
              "fixed": "1.39.3"
            }
          ]
        }
      ]
    }
  ],

And the release notes mentioning the CVE:

@darakian
Copy link
Contributor

darakian commented Nov 1, 2024

Looks good to me. Those release notes are fantastic! Let me get this going 👍

@advisory-database advisory-database bot merged commit 2e9fdf0 into Rudloff/advisory-improvement-4969 Nov 1, 2024
2 checks passed
@advisory-database
Copy link
Contributor

Hi @Rudloff! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

@advisory-database advisory-database bot deleted the Rudloff-GHSA-5vj8-g3qg-4qh6 branch November 1, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants