Allow for objects to be passed to lazyDefine, avoiding repeat calls #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AdamShwert <[email protected]> Co-authored-by: Arelia Jones <[email protected]> Co-authored-by: Chris Gavin <[email protected]> Co-authored-by: Cody Bodfield <[email protected]> Co-authored-by: Dusty Greif <[email protected]> Co-authored-by: Elena Tanasoiu <[email protected]> Co-authored-by: Erinna Chen <[email protected]> Co-authored-by: Francesco Manni <[email protected]> Co-authored-by: Jibran Garcia <[email protected]> Co-authored-by: Mamadou Coulibaly <[email protected]> Co-authored-by: Ned Schwartz <[email protected]>
keithamus
force-pushed
the
allow-for-objects-to-be-passed-to-lazydefine-avoiding-repeat-calls
branch
from
623860d
to
bd69f5d
Compare
Co-authored-by: Kristján Oddsson <[email protected]>
keithamus
force-pushed
the
allow-for-objects-to-be-passed-to-lazydefine-avoiding-repeat-calls
branch
from
8cc9495
to
3a8e33a
Compare
keithamus
deleted the
allow-for-objects-to-be-passed-to-lazydefine-avoiding-repeat-calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our mob pairing session called "Making Dotcom Fast" we ran into an issue where we're calling
lazyDefineover 200 times in quick succession. This becomes quite expensive ascancelAnimationFrameis O(n) and we're calling it 200 times meaning we end up with thousands of iterations that ultimately do nothing.In order to prevent this cost on page load, we can overload
lazyDefineto take an object of element->callback pairs, meaning we only callobserve()once. This then needs a tiny refactor on the consumer side, but it turns this:into this: