Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw configuration error when tar is not available #2611

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Throw configuration error when tar is not available #2611

merged 1 commit into from
Nov 18, 2024
+41 −30

Conversation

angelapwen
Copy link
Contributor

We recently had an internal monitor trigger when tar was not found on the PATH of a self-hosted runner. This change checks whether tar is available on the PATH and throws a configuration error when it is not. Small refactoring: I moved the isBinaryAccessible method to util now that it is used in multiple places.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@angelapwen angelapwen requested a review from a team as a code owner November 18, 2024 19:22
aeisenberg
aeisenberg approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@angelapwen angelapwen merged commit 9222a97 into main Nov 18, 2024
271 checks passed
@angelapwen angelapwen deleted the angelapwen/catch-tar-error branch November 18, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelapwen @aeisenberg