Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: have getId always return null if skipExtractingTypes is set #17831

Merged
merged 1 commit into from
Oct 24, 2024
Merged

JS: have getId always return null if skipExtractingTypes is set #17831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions javascript/extractor/lib/typescript/src/type_table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,7 @@ export class TypeTable {
* Returns `null` if we do not support extraction of this type.
*/
public getId(type: ts.Type, unfoldAlias: boolean): number | null {
if (this.skipExtractingTypes) return null;
let cached = this.idCache.get(type) ?? [undefined, undefined];
let cachedValue = cached[unfoldAlias ? 1 : 0];
if (cachedValue !== undefined) return cachedValue;
Expand Down
Loading