Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Consider the extraction of empty binlog files acceptable #17992

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

tamasvajk
Copy link
Contributor

This PR changes how empty binlog files are treated. Previously, the extractor returned a failed extraction error code in such a case:

[ERROR] Spawned process exited abnormally (code 2; tried to run: [.../extractor-csharp/csharp/tools/autobuild.sh])
A fatal error occurred: Exit status 2 from command: [...extractor-csharp/csharp/tools/autobuild.sh]

Now the behavior matches what we experience in traced mode, when no source code is found:

Finalizing database at .../DB1.
CodeQL did not detect any code written in languages supported by this CodeQL distribution (C#, XML, Java Properties Files or Java/Kotlin). Confirm that there is some source code for one of these languages in the project. For more information, review our troubleshooting guide at https://gh.io/troubleshooting-code-scanning/no-source-code-seen-during-build.

The exit code is:

❯ echo $?         
32

This change is in response to #17981 (comment).

@github-actions github-actions bot added the C# label Nov 15, 2024
@tamasvajk tamasvajk marked this pull request as ready for review November 15, 2024 15:09
@tamasvajk tamasvajk requested a review from a team as a code owner November 15, 2024 15:09
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tamasvajk tamasvajk merged commit b84b687 into github:main Nov 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants