Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: Reworked CWE-643 test cases #18066

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −11
Draft

JS: Reworked CWE-643 test cases #18066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion javascript/ql/test/query-tests/Security/CWE-643/XpathInjection.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Security/CWE-643/XpathInjection.ql
query: Security/CWE-643/XpathInjection.ql
postprocess: testUtilities/InlineExpectationsTestQuery.ql
4 changes: 2 additions & 2 deletions javascript/ql/test/query-tests/Security/CWE-643/XpathInjectionBad.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ const xpath = require('xpath');
const app = express();

app.get('/some/route', function(req, res) {
let userName = req.param("userName");
let userName = req.param("userName"); // $ Source

// BAD: Use user-provided data directly in an XPath expression
let badXPathExpr = xpath.parse("//users/user[login/text()='" + userName + "']/home_dir/text()");
let badXPathExpr = xpath.parse("//users/user[login/text()='" + userName + "']/home_dir/text()"); // $ Alert
badXPathExpr.select({
node: root
});
Expand Down
10 changes: 5 additions & 5 deletions javascript/ql/test/query-tests/Security/CWE-643/tst.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ const xpath = require('xpath');
const app = express();

app.get('/some/route', function(req, res) {
let tainted = req.param("userName");
xpath.parse(tainted); // NOT OK
xpath.select(tainted); // NOT OK
xpath.select1(tainted); // NOT OK
let tainted = req.param("userName"); // $ Source
xpath.parse(tainted); // $ Alert
xpath.select(tainted); // $ Alert
xpath.select1(tainted); // $ Alert
let expr = xpath.useNamespaces(map);
expr(tainted); // NOT OK
expr(tainted); // $ Alert
});
6 changes: 3 additions & 3 deletions javascript/ql/test/query-tests/Security/CWE-643/tst2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
let query = document.location.hash.substring(1);
document.createExpression(query); // NOT OK
document.evaluate(query); // NOT OK
let query = document.location.hash.substring(1); // $ Source
document.createExpression(query); // $ Alert
document.evaluate(query); // $ Alert