Improve test

github · Dec 13, 2022 · c7447c3 · c7447c3
1 parent 39022cf
commit c7447c3
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/go/logic/inspect_test.go b/go/logic/inspect_test.go
@@ -36,20 +36,25 @@ func TestRequiresBinlogFormatChange(t *testing.T) {
 	migrationContext := &base.MigrationContext{
 		InspectorServerInfo: &mysql.ServerInfo{},
 	}
-
+	inspector := &Inspector{migrationContext: migrationContext}
+	{
+		migrationContext.InspectorServerInfo.BinlogFormat = "ROW"
+		test.S(t).ExpectFalse(inspector.RequiresBinlogFormatChange())
+	}
+	{
+		migrationContext.InspectorServerInfo.BinlogFormat = ""
+		test.S(t).ExpectTrue(inspector.RequiresBinlogFormatChange())
+	}
 	{
 		migrationContext.InspectorServerInfo.BinlogFormat = "MINIMAL"
-		inspector := &Inspector{migrationContext: migrationContext}
 		test.S(t).ExpectTrue(inspector.RequiresBinlogFormatChange())
 	}
 	{
 		migrationContext.InspectorServerInfo.BinlogFormat = "MIXED"
-		inspector := &Inspector{migrationContext: migrationContext}
 		test.S(t).ExpectTrue(inspector.RequiresBinlogFormatChange())
 	}
 	{
-		migrationContext.InspectorServerInfo.BinlogFormat = "ROW"
-		inspector := &Inspector{migrationContext: migrationContext}
-		test.S(t).ExpectFalse(inspector.RequiresBinlogFormatChange())
+		migrationContext.InspectorServerInfo = nil
+		test.S(t).ExpectTrue(inspector.RequiresBinlogFormatChange())
 	}
 }