Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.12.0 #3221

Merged
merged 3 commits into from
Jan 11, 2024
Merged

v1.12.0 #3221

merged 3 commits into from
Jan 11, 2024

Conversation

norascheuch
Copy link
Contributor

Extension release PR.

Successful CLI tests run: https://github.com/github/vscode-codeql/actions/runs/7486817734

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@norascheuch norascheuch requested a review from a team as a code owner January 11, 2024 09:44
koesie10
koesie10 reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to check this before, but I think you'll need to change the header in the CHANGELOG.md from [UNRELEASED] to the new version and release date.

@norascheuch
Copy link
Contributor Author

Sorry I forgot to check this before, but I think you'll need to change the header in the CHANGELOG.md from [UNRELEASED] to the new version and release date.

Ah damn, you're right. Sorry for being so all over the place.

koesie10
koesie10 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@norascheuch norascheuch merged commit 24dff59 into main Jan 11, 2024
14 checks passed
@norascheuch norascheuch deleted the v1.12.0 branch January 11, 2024 12:23
@norascheuch norascheuch temporarily deployed to publish-vscode-marketplace January 11, 2024 12:25 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koesie10 koesie10 koesie10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norascheuch @koesie10