Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: main js #1207

Merged
merged 7 commits into from
Jun 10, 2024
Merged

refactor: main js #1207

merged 7 commits into from
Jun 10, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 8, 2024

update to closer match structure of examples

@setchy setchy added the refactor Refactoring of existing feature label Jun 8, 2024
@setchy setchy added this to the Release 5.8.0 milestone Jun 8, 2024
setchy
setchy commented Jun 8, 2024
View reviewed changes
main.js Show resolved Hide resolved
bmulholland
bmulholland approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge fan of this change. These types of updates are easy to overlook, but often solve hours of unnecessary debugging. Thanks!

setchy
setchy commented Jun 10, 2024
View reviewed changes
main.js Show resolved Hide resolved
@setchy setchy merged commit b017186 into main Jun 10, 2024
7 checks passed
@setchy setchy deleted the refactor/mainjs branch June 10, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@bmulholland bmulholland bmulholland approved these changes

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@setchy @bmulholland @afonsojramos