-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read environment variables #20
base: main
Are you sure you want to change the base?
Conversation
e15961e
to
3e6dd78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've left some notes
universal/test/operating_system/read_environment_variable.gleam
Outdated
Show resolved
Hide resolved
universal/test/operating_system/read_environment_variable.gleam
Outdated
Show resolved
Hide resolved
universal/test/operating_system/read_environment_variable.gleam
Outdated
Show resolved
Hide resolved
// First, unset the PORT variable. | ||
// | ||
// We do this fist to get the environment into a known state. If the PORT | ||
// variable is not already set, this will have no effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments should describe how perform each task, it shouldn't be telling a story. See the other examples for the style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully it now better matches what you want. It's more similar to the work_with_files.gleam example now.
universal/test/operating_system/read_environment_variable.gleam
Outdated
Show resolved
Hide resolved
universal/test/operating_system/read_environment_variable.gleam
Outdated
Show resolved
Hide resolved
Addresses gleam-lang#15
3e6dd78
to
046bed9
Compare
Addresses #15.