Read environment variables #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooreryan
force-pushed
the
environment-variables
branch
from
e15961e
to
3e6dd78
Compare
lpil
reviewed
Sep 23, 2024
universal/test/operating_system/read_environment_variable.gleam
Outdated
Show resolved
Hide resolved
universal/test/operating_system/read_environment_variable.gleam
Outdated
Show resolved
Hide resolved
universal/test/operating_system/read_environment_variable.gleam
Outdated
Show resolved
Hide resolved
| // First, unset the PORT variable. | ||
| // | ||
| // We do this fist to get the environment into a known state. If the PORT | ||
| // variable is not already set, this will have no effect. |
There was a problem hiding this comment.
The comments should describe how perform each task, it shouldn't be telling a story. See the other examples for the style
There was a problem hiding this comment.
Hopefully it now better matches what you want. It's more similar to the work_with_files.gleam example now.
universal/test/operating_system/read_environment_variable.gleam
Outdated
Show resolved
Hide resolved
universal/test/operating_system/read_environment_variable.gleam
Outdated
Show resolved
Hide resolved
Addresses gleam-lang#15
mooreryan
force-pushed
the
environment-variables
branch
from
3e6dd78
to
046bed9
Compare
lpil
approved these changes
Oct 21, 2024
|
Oops, the tests are failing! |
Looks like the javascript and erlang behavior on key not found is different. See here: lpil/envoy#3 |
lpil
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #15.