Clarify timeout is milliseconds #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed internal variable for `within` to timeout, now most functions use timeout as opposed to milliseconds, or `within` * Write documentation that timeout is expressed as milliseconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withinto timeout, now most functions use timeout as opposed to milliseconds, orwithinThe only function that remains is
select. It useswithin. I looked through thegleam_erlang_ffifile but it does not use anywithinparameters. Is it inferred somehow thatwithinis sent asTimeout? I do not know any erlang so I would need some help to clarify how the FFI understand which parameters are received on the erlang side.