implement send_bits #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Apr 19, 2024
| }; | ||
| if (method !== "GET" && method !== "HEAD") options.body = request.body.buffer; | ||
| return new globalThis.Request(url, options); | ||
| } |
There was a problem hiding this comment.
All the code here except .buffer is the same as the other function, let's extract that into one function.
There was a problem hiding this comment.
This looks better now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't really what to do regarding tests, so I haven't added any.
Might be helpful to add doc links to the actual services used.
Please feel free to run with this. I'm using it locally and don't have strong opinions on naming