-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(user): add default entity value = Full structure #17923
base: 10.0/bugfixes
Are you sure you want to change the base?
Conversation
'entity' => $entities | ||
'entity' => $entities, | ||
'toadd' => [ | ||
0 => __('Full structure'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 0
id is already used by the root entity.
This mean with this change I can't pick the root entity as my default anymore.
Is it on purpose ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It always has been this way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have access to the root entity, the behavior is the same between "full structure" and "tree structure." The difference only occurs when you do not have access to the root entity.
We cannot use -1
without modifying the database schema, and I'm not sure it's worth it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It always has been this way
What do you mean ?
Before this change, I can pick the root entity.
After this change, I can't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have access to the root entity, the behavior is the same between "full structure" and "tree structure." The difference only occurs when you do not have access to the root entity.
Maybe the root entity option should be removed then ?
Because right now if I click on the root entity it selects full structure instead.
It is likely that we will get support requests from people that will think it is a bug :/
Also, it seems a bit risky to add a new option like this directly in the bugfixes branch, no ? |
Checklist before requesting a review
Please delete options that are not relevant.
Description
Add Full structure value in user settings: