Add support for Python 3.7+ #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to confirm
This reverts commit b6dafe5.
Add comment for missing imports ignore that it's for zoneinfo
This reverts commit dfeded1.
|
@glyph would it be possible for you to take some time to review the PR? |
|
@m-aciek Sure, I'll have a look. Per https://endoflife.date/python, 3.7 is unsupported, but given that this is a load-bearing piece of infrastructure it seems worthwhile to have a bit of extra long-tail support. Plus, I did say I'd look at your PR :). I'll do a release, but you should expect 3.7 support to be fairly short-lived. |
This commit was sponsored by Jason Walker, Matt Campbell, Sergio Bost, and my other patrons. If you want to join them, you can support my work at https://patreon.com/creatorglyph.
This commit was sponsored by Matt Campbell, Sergio Bost, Jason Walker, and my other patrons. If you want to join them, you can support my work at https://patreon.com/creatorglyph.
|
@m-aciek This is included in a new release here: https://pypi.org/project/datetype/2024.2.8/ |
|
Thank you very much! |
|
You're welcome! Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to make NaiveDateTime/AwareDateTime work properly for Python 3.7 due to interface incompatibilities. Only Date/DateTime is supported as expected for Python 3.7. Full functionality for Python 3.8+.
Closes #6.