Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnoweb): connect with Adena Wallet for Sign and Broadcast #2794

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

AnhVAR
Copy link

@AnhVAR AnhVAR commented Sep 13, 2024

Add feature for user can connect Adena to get wallet address, sign and broadcast message direct on gnoweb.
Demo video: https://drive.google.com/file/d/1T4yPOWzVZKfg_iTAhZ7iseLzUD63oqE3/view?usp=sharing

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@AnhVAR AnhVAR requested review from moul, zivkovicmilos and a team as code owners September 13, 2024 10:00
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Sep 13, 2024
@AnhVAR AnhVAR changed the title [gnoweb] connect with Adena Wallet for Sign and Broadcast feat(gnoweb) connect with Adena Wallet for Sign and Broadcast Sep 13, 2024
@AnhVAR AnhVAR changed the title feat(gnoweb) connect with Adena Wallet for Sign and Broadcast feat(gnoweb): connect with Adena Wallet for Sign and Broadcast Sep 13, 2024
@thehowl
Copy link
Member

thehowl commented Sep 13, 2024

ping @alexiscolin for first review / understanding how this fits in our plans for gnoweb.

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This work is promising; however, we need to take a slightly different approach to ensure it is done correctly. We can certainly reuse some of the logic from your PR.

See #2799.

@Kouteki Kouteki added review team PRs that should be reviewed first by the review team or external contributors and removed review team PRs that should be reviewed first by the review team or external contributors labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: In Progress
Status: In Review
Development

Successfully merging this pull request may close these issues.

6 participants