-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gnoweb): connect with Adena Wallet for Sign and Broadcast #2794
Open
AnhVAR
wants to merge
32
commits into
gnolang:master
Choose a base branch
from
VAR-META-Tech:dev_gnoweb_adena
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧾 package/realm
Tag used for new Realms or Packages.
📦 ⛰️ gno.land
Issues or PRs gno.land package related
labels
Sep 13, 2024
…ll-dice Revert "Implement game roll dice"
AnhVAR
changed the title
[gnoweb] connect with Adena Wallet for Sign and Broadcast
feat(gnoweb) connect with Adena Wallet for Sign and Broadcast
Sep 13, 2024
AnhVAR
changed the title
feat(gnoweb) connect with Adena Wallet for Sign and Broadcast
feat(gnoweb): connect with Adena Wallet for Sign and Broadcast
Sep 13, 2024
ping @alexiscolin for first review / understanding how this fits in our plans for gnoweb. |
moul
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This work is promising; however, we need to take a slightly different approach to ensure it is done correctly. We can certainly reuse some of the logic from your PR.
See #2799.
Kouteki
added
review team
PRs that should be reviewed first by the review team or external contributors
and removed
review team
PRs that should be reviewed first by the review team or external contributors
labels
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 ⛰️ gno.land
Issues or PRs gno.land package related
🧾 package/realm
Tag used for new Realms or Packages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature for user can connect Adena to get wallet address, sign and broadcast message direct on gnoweb.
Demo video: https://drive.google.com/file/d/1T4yPOWzVZKfg_iTAhZ7iseLzUD63oqE3/view?usp=sharing
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description