Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add p/moul/helplink #2887

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add p/moul/helplink #2887

wants to merge 5 commits into from

Conversation

moul
Copy link
Member

@moul moul commented Oct 2, 2024

This PR aimed to promote the use of a p/ library for managing special help links from contracts.

It also provided an opportunity for me to realize that our discussion about changing the $ symbol would require some parsing and detection from the gnoweb perspective. If we want a simple library like this one, the goal should be to ideally craft a link to the current package without specifying the realm path. Relative URLs worked well with ?, but they won't function with $.

As an alternative, we can have this package look for std.PrevRealm().PkgAddr if it is not specified.

cc @jeronimoalbi @thehowl @leohhhn

Related with #2602
Related with #2876

@moul moul self-assigned this Oct 2, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Oct 2, 2024
Signed-off-by: moul <[email protected]>
@moul moul marked this pull request as ready for review October 2, 2024 17:14
@moul moul requested review from a team as code owners October 2, 2024 17:14
@moul moul requested review from n2p5 and mvertes and removed request for a team October 2, 2024 17:14
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (8a62a28) to head (c214869).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2887      +/-   ##
==========================================
+ Coverage   60.95%   60.96%   +0.01%     
==========================================
  Files         564      564              
  Lines       75273    75273              
==========================================
+ Hits        45884    45892       +8     
+ Misses      26019    26011       -8     
  Partials     3370     3370              
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
gno.land 67.92% <ø> (ø)
gnovm 65.77% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.12% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: 📥 Inbox
Status: Agenda
Status: Triage
Development

Successfully merging this pull request may close these issues.

1 participant