New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: r/demo/foo20airdrop - Merkle Airdrop contract example #906

Open

albttx wants to merge 4 commits into gnolang:master from albttx:r/foo20-airdrop

+323 −0

Member

albttx commented Jun 16, 2023

Description

This PR bring an example for a merkle airdrop contract.

the package p/demo/airdrop
the realm r/demo/foo20airdrop

How it's works ?

A merkle airdrop contract works by saving off-chain the elements of the merkle tree. ONLY the Merkle root is saved on the realm.

To confirm an element is present, we just need to send to the contract a merkle proof.

albttx requested review from jaekwon, moul and a team as code owners

June 16, 2023 13:00

albttx self-assigned this

albttx marked this pull request as draft

June 16, 2023 13:01

github-actions bot added 📦 🤖 gnovm 🧾 package/realm labels

Member Author

albttx commented Jun 16, 2023

waiting for: #893 and #895 to undraft

albttx force-pushed the r/foo20-airdrop branch 2 times, most recently from 2060eff to 2675ea9 Compare

July 23, 2023 12:42

github-actions bot removed the 📦 🤖 gnovm label

albttx force-pushed the r/foo20-airdrop branch from 2675ea9 to 08a8ac6 Compare

July 23, 2023 12:44

albttx changed the title ~~r/demo/foo20airdrop - Merkle Airdrop contract example~~ feat: r/demo/foo20airdrop - Merkle Airdrop contract example

albttx force-pushed the r/foo20-airdrop branch from 08a8ac6 to 7c384db Compare

July 23, 2023 12:53

albttx marked this pull request as ready for review

July 26, 2023 15:18

tbruyelle reviewed

View reviewed changes

examples/gno.land/r/demo/foo20-airdrop/airdrop_test.gno

    
              func TestClaimAirdrop(t *testing.T) {

              	contractAddr := std.DerivePkgAddr("gno.land/r/demo/foo20-airdrop")

              	std.TestSetOrigCaller(contractAddr)

Contributor

tbruyelle Jul 26, 2023

Do you still need that ?

p/demo/foo20 uses std.PrevRealm() now right ?

moul reviewed

View reviewed changes

examples/gno.land/p/demo/airdrop/merkle-airdrop.gno Outdated

+              	"crypto/sha256"
+              	"encoding/hex"
+              	"errors"
+              	"fmt"

Member

moul Jul 27, 2023

doesn't work yet

moul reviewed

View reviewed changes

examples/gno.land/p/demo/airdrop/merkle-airdrop.gno Outdated Show resolved Hide resolved

moul reviewed

View reviewed changes

examples/gno.land/p/demo/airdrop/merkle-airdrop.gno Outdated

		@@ -0,0 +1,88 @@
		package airdrop

Member

moul Jul 27, 2023

p/demo/airdrop seems to be too generic IMO, so I would either name it accurately like p/demo/grc20_merkle_airdrop or use a subpaths, maybe p/demo/airdrop/grc20_merkle.

moul reviewed

View reviewed changes

examples/gno.land/p/demo/airdrop/merkle-airdrop.gno Outdated

+              type AirdropData struct {
+              	Address std.Address
+              	// TODO: use std.Coin
+              	Amount uint64

Member

moul Jul 27, 2023

For better control and data integrity, keep the fields in the Airdrop struct unexported.

To maintain easy marshaling with the Bytes helper, consider this approach:

type Airdrop struct {
    data struct {
        Address std.Address
        Amount  uint64
    }
}

zivkovicmilos approved these changes

View reviewed changes

Member

zivkovicmilos left a comment

Looks good 💯

Please see @moul's comments, otherwise we should be good to go

examples/gno.land/p/demo/airdrop/merkle-airdrop.gno Outdated Show resolved Hide resolved

examples/gno.land/p/demo/airdrop/merkle-airdrop_test.gno Outdated Show resolved Hide resolved

examples/gno.land/r/demo/foo20-airdrop/airdrop.gno Show resolved Hide resolved

examples/gno.land/r/demo/foo20-airdrop/airdrop.gno Outdated Show resolved Hide resolved

examples/gno.land/r/demo/foo20-airdrop/airdrop.gno Outdated Show resolved Hide resolved

examples/gno.land/r/demo/foo20-airdrop/airdrop_test.gno Show resolved Hide resolved

examples/gno.land/r/demo/foo20-airdrop/airdrop_test.gno Outdated Show resolved Hide resolved

examples/gno.land/r/demo/foo20-airdrop/airdrop_test.gno Outdated Show resolved Hide resolved

examples/gno.land/r/demo/foo20-airdrop/airdrop_test.gno Outdated Show resolved Hide resolved

examples/gno.land/r/demo/foo20-airdrop/airdrop_test.gno Outdated Show resolved Hide resolved

moul requested changes

View reviewed changes

Member

moul left a comment

Just blocking since there are several changes. Let’s make an additional round of reviews.

moul marked this pull request as draft

August 6, 2023 23:07

michelleellen mentioned this pull request

Gno.land Developer Call Agenda {09.08.2023}_ #11 gnolang/meetings#25

Closed

16 tasks

Member Author

albttx commented Aug 9, 2023

There is tests issue once rebased with master.

There is a situation to figure out, with grc20.IGRC20, because it return a grc20.UserToken .

When user1.gno -> r/foo20-airdrop get foo20.GRC20() and then from r/foo20-airdrop exec foo20.GRC20().Transfert, std.PrevRealm isn't the realm but the user ...

Possible fix could be to update in user_token.gno to use CurrentRealm rather than PrevRealm

Member

moul commented Aug 9, 2023

Related (and depending?) on #952

Member

zivkovicmilos commented Aug 16, 2023

What's the status of this PR?

moul added this to the 🌟 main.gno.land (wanted) milestone

albttx force-pushed the r/foo20-airdrop branch from 7c384db to 2588613 Compare

October 18, 2023 20:47

github-actions bot added the 📦 🤖 gnovm label

albttx force-pushed the r/foo20-airdrop branch from 2588613 to 6b06c76 Compare

October 18, 2023 21:14

codecov bot commented Oct 18, 2023 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.95%. Comparing base (8a62a28) to head (799a02f).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   60.95%   60.95%   -0.01%     
==========================================
  Files         564      564              
  Lines       75273    75273              
==========================================
- Hits        45884    45879       -5     
- Misses      26019    26022       +3     
- Partials     3370     3372       +2

Flag	Coverage Δ
contribs/gnodev	`61.46% <ø> (ø)`
contribs/gnofaucet	`14.46% <ø> (ø)`
gnovm	`65.77% <ø> (ø)`
misc/genstd	`80.54% <ø> (ø)`
misc/logos	`20.23% <ø> (+0.35%)`	⬆️
tm2	`62.01% <ø> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Contributor

thinhnx-var commented Oct 4, 2024

Excuse me, can you let me know the current status of this idea @albttx ?

Member Author

albttx commented Oct 4, 2024

It was blocked by #1257 for a long time, i just realized it has been merged!

I'll fixup this PR :)


          chore: foo20-airdrop

albttx force-pushed the r/foo20-airdrop branch from 9cf2f47 to 7497268 Compare

October 4, 2024 11:09

albttx added 2 commits

October 4, 2024 12:11


          chore: fmt

51c55c5


          fix: transpile

2ed4595

albttx marked this pull request as ready for review

October 4, 2024 11:24

albttx requested a review from a team as a code owner

October 4, 2024 11:24


          chore: fmt

799a02f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 🤖 gnovm 🧾 package/realm