Implement rename branch API #32433
Open
Implement rename branch API #32433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/api
kemzeb
commented
Nov 6, 2024
kemzeb
commented
Nov 6, 2024
silverwind
added
the
type/feature
lunny
reviewed
Nov 6, 2024
Co-authored-by: sillyguodong <[email protected]>
kemzeb
force-pushed
the
feat-api-add-rename-branch
branch
from
1beebeb
to
36829ec
Compare
wxiaoguang
reviewed
Nov 17, 2024
lunny
reviewed
Nov 18, 2024
| } | ||
|
|
||
| branchName := opt.Name | ||
| if branchName != "" { |
There was a problem hiding this comment.
How about return error if branchName is empty?
There was a problem hiding this comment.
Since this is now a PATCH request I didn't know if it would be alright having the name field be required.
Then again it is the only field that I could think of that could be updated for a branch, so it maybe make more sense to make it required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22526.
Builds upon #23061.