-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): library and database types #339
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: adding dashboard field to user data type * fix: fixing tests * fix: fixing parsing int --------- Co-authored-by: Claire.Nicholas <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
- Coverage 96.54% 96.38% -0.16%
==========================================
Files 69 72 +3
Lines 5330 5540 +210
==========================================
+ Hits 5146 5340 +194
- Misses 110 126 +16
Partials 74 74
|
Closing with migration of types -> server: go-vela/server#1028 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing on a concept where users can create pages wherein they can look at a collection of repositories at a high level. Below is a simple mock up of the eventual UI:
This back-end struct design accounts for a few key features: share-ability, admin access, and customizability.
Share-ability: using a uniquely generated UUID that will serve as the
link
to the dashboard along with user-specificuser.Dashboards
we will be able to allow open navigation to any dashboard via a link + easy navigation through the UI via "My Dashboards", much like many group-board applications such as Draw IO, Miro, etc.Admin Access: since the dashboards will be public and discoverable, it's important to limit update/delete access. This can be done via the
Dashboard.Admins
field, which holds a slice of user_ids capable of editing the dashboard. There is also auditing in place in the form ofcreated_at
,created_by
,updated_at
,updated_by
.Customizability: choosing to store the dashboard repo collection as a JSON field allows users to customize their "subscription" to that repo, using the
Events
andBranches
field. While it would have been possible to reference repositories in a slice field of repo_ids, that way makes customization to this degree much more challenging.The server-side implementation is this can be found, in draft form, here