fix: binary installation, checksums, cleanup

[plyr4]

⚠️ required changes for terraform v >= 1.8, see: hashicorp/terraform#35075

• adds checksum validation to the Dockerfile's default terraform binary installation
• removes PHONY references in make (redacted)
• migrates from go-getter to hc-install based on recommendations from hashicorp over breaking changes made to the way terraform is zipped and released.

inspiration for code changes are from runatlantis/atlantis#4494

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.26%. Comparing base (64f00a5) to head (0998100).
Report is 1 commits behind head on main.

Files	Patch %	Lines
cmd/vela-terraform/main.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   40.68%   41.26%   +0.57%     
==========================================
  Files          12       12              
  Lines         757      761       +4     
==========================================
+ Hits          308      314       +6     
+ Misses        437      434       -3     
- Partials       12       13       +1     

Files	Coverage Δ
cmd/vela-terraform/terraform.go	85.71% <100.00%> (+8.29%)	⬆️
cmd/vela-terraform/main.go	1.25% <0.00%> (ø)

[wass3rw3rk]

why the PHONY removal? i understand the chance we have a file named any of the targets is low (in which case i believe it would do nothing), but it's used to indicate non-file targets and is consistent with other repos. it adds minimal noise and is technically correct?

one could open the can-o-worms of should we even use Makefiles to start with?

[plyr4]

why the PHONY removal? i understand the chance we have a file named any of the targets is low (in which case i believe it would do nothing), but it's used to indicate non-file targets and is consistent with other repos. it adds minimal noise and is technically correct?

one could open the can-o-worms of should we even use Makefiles to start with?

it was an item on our internal roadmap to consolidate and remove phony usage to bring these all to a consistent standard.
i dont know who recommended it initially.

dont shoot the messenger!

[plyr4]

i removed the removal of phony. to be honest i dont care if its there, i was just following blindly.
i'd rather not muddle this PR which is actually fixing something. thanks for the review, i appreciate it

[wass3rw3rk]

love the checksum check addition. one suggestion. since it works as-is, i'll approve. happy to re-approve if you decide to take it up.