fix: install curl in final image layer #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving
apk add curl
to the final image layer.i understand grouping them would be ideal, but that requires a
COPY
from one alpine layer to another alpine layer.which is fine, but you would need to also COPY the following shared libraries to make it actually work:
to me, just doing an
apk add curl
in the final image is more sustainable and readable, considering its not even a scratch image, its alpine.any thoughts? im open to other suggestion, im also open to just copying those shared libs, but it feels like maintenance hell