Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consistent golangci lint config #184

Merged
merged 2 commits into from
Aug 20, 2024
Merged

chore: consistent golangci lint config #184

merged 2 commits into from
Aug 20, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Aug 20, 2024

applying consistent linting across repos, see https://github.com/go-vela/server/blob/main/.golangci.yml

@plyr4 plyr4 requested a review from a team as a code owner August 20, 2024 16:47
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.26%. Comparing base (45d87ef) to head (95a4071).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   41.26%   41.26%           
=======================================
  Files          12       12           
  Lines         761      761           
=======================================
  Hits          314      314           
  Misses        434      434           
  Partials       13       13           
Files Coverage Δ
cmd/vela-terraform/apply.go 94.00% <ø> (ø)
cmd/vela-terraform/destroy.go 93.75% <ø> (ø)
cmd/vela-terraform/fmt.go 90.00% <ø> (ø)
cmd/vela-terraform/main.go 1.25% <ø> (ø)
cmd/vela-terraform/plan.go 82.69% <ø> (ø)
cmd/vela-terraform/terraform.go 85.71% <ø> (ø)
cmd/vela-terraform/validate.go 90.62% <ø> (ø)
version/version.go 0.00% <ø> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit bcf115e into main Aug 20, 2024
11 of 12 checks passed
@plyr4 plyr4 deleted the chore/linter branch August 20, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants