Displaying if a lesson in the syllabus has a quiz, assignment, or both #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhogg
reviewed
Nov 14, 2024
| @@ -63,6 +63,31 @@ | |||
| do_action( 'llms_lesson_preview_before_title', $lesson ) | |||
| ?> | |||
| <div class="llms-lesson-title"><?php echo esc_html( get_the_title( $lesson->get( 'id' ) ) ); ?></div> | |||
|
|
|||
| <?php | |||
| $has_quiz = $lesson->is_quiz_enabled(); | |||
There was a problem hiding this comment.
Not a huge deal but could we put this inline within the if rather than having a temp variable $has_quiz that we don't use again?
| ?> | ||
|
|
||
| <?php | ||
| // Does the lesson have an assignment? |
There was a problem hiding this comment.
Could we remove the "what" comment since the llms_lesson_has_assignment function shows this already? I've been cleaning up any what-type comments especially since the "what" can change and the comment doesn't get updated down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now showing if a lesson in the Course Syllabus has a quiz, assignment, or has both.
How has this been tested?
Locally
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: