Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkpoint of optional dependency approach #189

Closed
wants to merge 1 commit into from
Closed

checkpoint of optional dependency approach #189

wants to merge 1 commit into from

Conversation

sushantmimani
Copy link
Contributor

  • initial implementation of using optional dependencies for ALL: Make dependencies optional where possible #36
  • not ready for PR yet. we should verify this is the right approach. just wanted to push up local changes for reference
  • reference apps and test app show the approach end users would need to pull in dependencies they'd want
  • still need documentation changes

@jpaskhay
checkpoint of optional dependency approach
68715f3 
- initial implementation of using optional dependencies for #36
- not ready for PR yet. we should verify this is the right approach. just wanted to push up local changes for reference
- reference apps and test app show the approach end users would need to pull in dependencies they'd want
- still need documentation changes
@nikoo28 nikoo28 reopened this May 19, 2020
@nikoo28 nikoo28 marked this pull request as draft May 19, 2020 19:44
@sushantmimani sushantmimani deleted the optional_dependencies branch February 1, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sushantmimani @nikoo28 @jpaskhay