Fix updated Android IAP project in c# #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mono-4_3 # Conflicts: # mono/android_iap/GodotGooglePlayBilling/GooglePlayBilling.cs
|
There have some problem with the PR. Sorry for that. I'm learning to do them properly |
Calinou
approved these changes
Aug 24, 2024
Calinou
reviewed
Aug 24, 2024
mono/android_iap/project.godot
Outdated
Comment on lines
33
to
34
| renderer/rendering_method="mobile" | ||
| textures/vram_compression/import_etc2_astc=true |
There was a problem hiding this comment.
Please change this back to Compatibility, as that rendering method works better on most mobile devices (including low-end ones).
This is because the mobile rendering method uses Vulkan, and many mobile devices don't support it (or poorly).
aaronfranke
requested changes
Aug 27, 2024
aaronfranke
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After my previous update of the project [#1104] to port it to Godot 4.3 and adapt the code to the new API, I found that it failed to work on build.
I used debug from mobile device and I found that the app was unable to access certain dynamic libraries for some reason.
Despite this, one of my personal projects were I was using this code worked perfectly well so I thought it was something related to the version of the GodotBillingPlugin used.
I added the last version 1.2.0 and reconstructed the project just in case it was something else and I finally could get it working.
Moreover, I fixed a problem with signal strings that I found after connecting the app with Google Play and setting up everything needed to do purchases.