Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Invalid ClickHouse Docs #1158

Open
wants to merge 17 commits into
base: development
Choose a base branch
from

Conversation

FilledEther20
Copy link
Contributor

@FilledEther20 FilledEther20 commented Oct 29, 2024

Pull Request

Description:

  • Closes Invalid Clickhouse godocs #1081 is being tackled through this PR.
  • The update ensures that only the relevant Clickhouse package documentation is highlighted, improving both readability and maintainability of the code.

Checklist:

  • I have formatted my code using goimport and golangci-lint.
  • This PR does not decrease the overall code coverage.
  • I have reviewed the code comments and documentation for clarity.

Thank You
Screenshot 2024-10-29 at 10 50 30 AM

@vipul-rawat vipul-rawat changed the title Fix_Issue#1081_Invalid_Clickhouse_Docs Fix: Invalid ClickHouse Docs Oct 29, 2024
@@ -1,3 +1,6 @@
//go:build exclude
// +build exclude
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly related to this PR, but this syntax is outdated for a while I think.

https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md

@vipul-rawat @Umang01-hash Maybe an new issue/another PR could be created

What do you think?

Copy link
Contributor

@ccoVeille ccoVeille Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a similar issue about the problem I raised today

stretchr/testify#1671

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Clickhouse godocs
5 participants