Fixed leading white space stripping and added new options to iOS LlmInference #5635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name in iOS LlmInference
|
|
||
| llmSessionRunner.predictAsync( | ||
| progress: { partialResponseStrings, error in | ||
| guard let responseStrings = partialResponseStrings, | ||
| let humanReadableLlmResponse = Session.humanReadableString( | ||
| llmResponses: responseStrings, stripLeadingWhitespaces: receivedFirstToken) | ||
| llmResponses: responseStrings, stripLeadingWhitespaces: !receivedFirstNonEmptyToken) | ||
| else { |
There was a problem hiding this comment.
@yishuangP I have changed the name of the state variable and the values it takes in different scenarios to map closely to the meaning of the variable name for better readability. So the condition check for leading white space stripping is flipped. The logic remains the same as the previous implementation.
yishuangP
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed leading whitespace by stripping only leading white spaces from first non empty response.
Previous implementation was stripping whitespaces from both ends only for the first response irrespective of whether empty/non-empty.
Added new options